View unanswered posts | View active topics It is currently 24 Oct 2020, o 10:30



Reply to topic  [ 1 post ] 
 Very minor flag decal/national name mismatch 
Author Message
Trainee

Joined: 16 Oct 2020, o 12:30
Posts: 1
Post Very minor flag decal/national name mismatch
Hello,

Not sure if this has already been reported, but there is a mismatch of flag decal and national name for South China: The flag decal is for the Qin dynasty, but the name says Southern Song dynasty (see attached file). Turns out the Song dynasty flag is actually included in the assets! It was just an oversight in the DynamicCivNaming.py file. I have fixed it in my local version and confirm it does work (after civic change)

Typo is on ln. 562 of DynamicCivNaming.py

Code:
                     ["", "TXT_KEY_CIV_SOUTH_CHINA_MON_MED_DESC", "", "KEY_SHORT", "KEY_ADJ", "mon", "1"]],

should be
Code:
                     ["", "TXT_KEY_CIV_SOUTH_CHINA_MON_MED_DESC", "", "KEY_SHORT", "KEY_ADJ", "mmo", "1"]],


This is a really minor fix that doesn't warrant an entirely new update, but just a heads up to fix this.


Attachments:
File comment: Correct file exists in art assets, name is south_china_mmo.dds
correct_flag.PNG
correct_flag.PNG [ 8.29 KiB | Viewed 235 times ]
File comment: Flag/Name mismatch for S. China
qin_song.png
qin_song.png [ 770.02 KiB | Viewed 235 times ]
16 Oct 2020, o 12:44
Profile
Display posts from previous:  Sort by  
Reply to topic   [ 1 post ] 

Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by STSoftware for PTF.